Security: Add SSRF and local resource access protection#31
Open
Jah-yee wants to merge 3 commits intogarrytan:mainfrom
Open
Security: Add SSRF and local resource access protection#31Jah-yee wants to merge 3 commits intogarrytan:mainfrom
Jah-yee wants to merge 3 commits intogarrytan:mainfrom
Conversation
- Add validateOutputPath() to restrict output paths to /tmp or CWD - Add validateFilePath() to prevent arbitrary file read via eval - Resolves issue garrytan#13 (path traversal allows arbitrary file read/write)
The browse skill had no model specified in the frontmatter, causing it to use the user's default model (usually Opus) by default. Since browse is orchestrating CLI commands with minimal reasoning required, Sonnet is more cost-effective while maintaining good performance. This addresses issue garrytan#8.
- Add url-validator.ts with validateUrl() function - Blockfile:// URLs by default (opt-in with --allow-file) - Block localhost, 127.0.0.1, ::1 - Block RFC1918 private IP ranges (opt-in with --allow-private) - Block cloud metadata endpoints (169.254.x.x) - Block .internal and .localhost hostnames - Apply validation to goto, newTab, and diff commands Fixes: garrytan#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds URL validation to prevent Server-Side Request Forgery (SSRF) and local resource access attacks in the
browsecommand.Changes
Added
url-validator.tswith avalidateUrl()function that:file://URLs by default (opt-in with--allow-file)localhost,127.0.0.1,::1)--allow-private)169.254.169.254).internaland.localhosthostnamesApplied validation to:
gotocommand inwrite-commands.tsnewTab()method inbrowser-manager.tsdiffcommand inmeta-commands.tsFixes
Fixes #17